Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: frog/member.dart

Issue 8912017: Fix missing trampolines for named arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: remove comment Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/gen.dart ('k') | frog/minfrog » ('j') | frog/var_member.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/member.dart
diff --git a/frog/member.dart b/frog/member.dart
index d6b1b7d9a64837683e7cf7d27efc0ca4e58f1fd1..87da67a77a9664327b3efe140c52fea70efdf242 100644
--- a/frog/member.dart
+++ b/frog/member.dart
@@ -817,6 +817,18 @@ class MethodMember extends Member {
return new Value(functionType, '${target.code}.get\$$jsname()', node.span);
}
+ bool namesInHomePositions(Arguments args) {
Jennifer Messerly 2011/12/14 19:15:33 mind adding a comment to this? I'm not familiar wi
sra1 2011/12/14 22:04:32 Done.
+ if (!args.hasNames) return true;
+
+ for (int i = args.bareCount; i < args.values.length; i++) {
+ if (i >= parameters.length)
Jennifer Messerly 2011/12/14 19:15:33 style nit: ifs should be one line, or use { ... }
sra1 2011/12/14 22:04:32 Done.
+ return false;
+ if (args.getName(i) != parameters[i].name)
+ return false;
+ }
+ return true;
+ }
+
bool namesInOrder(Arguments args) {
if (!args.hasNames) return true;
« no previous file with comments | « frog/gen.dart ('k') | frog/minfrog » ('j') | frog/var_member.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698