Fix missing trampolines for named arguments.

frog/member.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** A formal parameter to a [Method]. */
 class Parameter {
   FormalNode definition;
   Member method;
 
   String name;
@@ skipping 799 matching lines @@
       // TODO(sigmund): can we avoid generating the entire type, but only what
       // we need?
       declaringType.markUsed();
       var type = declaringType.isTop ? '' : '${declaringType.jsname}.';
       return new Value(functionType, '$type$jsname', node.span);
     }
     _providePropertySyntax = true;
     return new Value(functionType, '${target.code}.get\$$jsname()', node.span);
   }
 
+  bool namesInHomePositions(Arguments args) {

[Jennifer Messerly, 2011/12/14 19:15:33]

mind adding a comment to this? I'm not familiar with the term "home positions"

I was wondering if this works for cases like:

class Foo { foo(a,[b=1,c=2,d=3]) { print(d); } }
main() { var f = new Foo(); f.foo(0,b:4,c:5); }

... discovered, it does, because _useDirectCall checks that any trailing default
args are null.

[sra1, 2011/12/14 22:04:32]

Done.

+    if (!args.hasNames) return true;
+
+    for (int i = args.bareCount; i < args.values.length; i++) {
+      if (i >= parameters.length)

[Jennifer Messerly, 2011/12/14 19:15:33]

style nit: ifs should be one line, or use { ... }

[sra1, 2011/12/14 22:04:32]

Done.

+        return false;
+      if (args.getName(i) != parameters[i].name)
+        return false;
+    }
+    return true;
+  }
+
   bool namesInOrder(Arguments args) {
     if (!args.hasNames) return true;
 
     int lastParameter = null;
     for (int i = args.bareCount; i < parameters.length; i++) {
       var p = args.getIndexOfName(parameters[i].name);
       // Only worry about parameters that needTemps. Otherwise it's fine to
       // reorder.
       if (p >= 0 && args.values[p].needsTemp) {
         if (lastParameter != null && lastParameter > p) {
@@ skipping 948 matching lines @@
   }
 
   void forEach(void f(Member member)) {
     factories.forEach((_, Map constructors) {
       constructors.forEach((_, Member member) {
         f(member);
       });
     });
   }
 }