Issue 8911001: Add -Wno-array-bounds to SConstruct for PNaCl GlibC build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8911001: Add -Wno-array-bounds to SConstruct for PNaCl GlibC build. (Closed)

Created:
9 years ago by pdox

Modified:
9 years ago

Reviewers:
jvoung - send to chromium...

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

Add -Wno-array-bounds to SConstruct for PNaCl GlibC build. GlibC's strpbrk is implemented by a macro which uses short-circuiting with the ternary operator to quickly evaluate the case for 0, 1, 2, or 3 length strings. For some reason, this construction triggers Clang's array-bounds detection. I've filed an LLVM bug for this: http://llvm.org/bugs/show_bug.cgi?id=11536 TBR= jvoung BUG= http://llvm.org/bugs/show_bug.cgi?id=11536 TEST= PNaCl GLibC bot Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=7408

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	SConstruct	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm