Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: SConstruct

Issue 8911001: Add -Wno-array-bounds to SConstruct for PNaCl GlibC build. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: SConstruct
===================================================================
--- SConstruct (revision 7407)
+++ SConstruct (working copy)
@@ -535,6 +535,12 @@
# Allow variadic macros
werror_flags = werror_flags + ['-Wno-variadic-macros']
+# Clang Bug:
+# array-bounds detection gives false positive on valid code in GLibC.
+# BUG= http://llvm.org/bugs/show_bug.cgi?id=11536
+if pre_base_env.Bit('bitcode') and pre_base_env.Bit('nacl_glibc'):
+ werror_flags += ['-Wno-array-bounds']
+
# ----------------------------------------------------------
# Method to make sure -pedantic, etc, are not stripped from the
# default env, since occasionally an engineer will be tempted down the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698