Patch AvatarMenuBubbleView crash; only SizeToContents if GetBubbleFrameView.

Patch AvatarMenuBubbleView crash; only SizeToContents if GetBubbleFrameView.

Showing the avatar menu crashes after crrev.com/114330.
SizeToContents was called before BubbleFrameView init.

This workaround checks GetBubbleFrameView before calling SizeToContents.
Also, run OnAvatarMenuModelChanged on Init, not ctor.

BUG=106989, 107574
TEST=No crash and doesn't regress crbug.com/106989.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114538

[sail, 2011-12-14 21:34:34]

lgtm

[msw, 2011-12-14 21:41:26]

Sky, PTAL; thanks! This fixes a top crasher.

[sky, 2011-12-14 22:18:38]

LGTM

[commit-bot: I haz the power, 2011-12-14 22:23:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/8909013/6

[Peter Kasting, 2011-12-14 22:41:56]

http://codereview.chromium.org/8909013/diff/6/chrome/browser/ui/views/avatar_...
File chrome/browser/ui/views/avatar_menu_bubble_view.cc (left):

http://codereview.chromium.org/8909013/diff/6/chrome/browser/ui/views/avatar_...
chrome/browser/ui/views/avatar_menu_bubble_view.cc:140: 
Nit: Don't remove this.

(Besides, you didn't remove e.g. line 127.)

[msw, 2011-12-14 22:49:51]

I'll re-add the blank line (Peter's nit), and investigate a more correct
solution in a follow-up CL. BubbleDelegateView should probably call
SizeToContents on [Child]PreferredSizeChanged, or similar. For now, this seems
acceptable.

[commit-bot: I haz the power, 2011-12-15 00:02:22]

List of reviewers changed. pkasting@chromium.org did a drive-by without
LGTM'ing!

[Peter Kasting, 2011-12-15 01:44:38]

LGTM