ui/views/bubble/bubble_delegate.h - Issue 8909013: Patch AvatarMenuBubbleView crash; only SizeToContents if GetBubbleFrameView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_delegate.h

Issue 8909013: Patch AvatarMenuBubbleView crash; only SizeToContents if GetBubbleFrameView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Run OnAvatarMenuModelChanged on Init, not ctor. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/avatar_menu_bubble_view.cc ('K') | « chrome/browser/ui/views/avatar_menu_bubble_view.cc ('k') | ui/views/bubble/bubble_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/bubble/bubble_delegate.h

diff --git a/ui/views/bubble/bubble_delegate.h b/ui/views/bubble/bubble_delegate.h

index 01bd5186e137c5445d97814957dde6cd1078f3b1..1c73e14b19c9abd39acf4d41d9c7e9675423c7d0 100644

--- a/ui/views/bubble/bubble_delegate.h

+++ b/ui/views/bubble/bubble_delegate.h

@@ -107,12 +107,12 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView,

// contents preferred size.

void SizeToContents();

+ BubbleFrameView* GetBubbleFrameView() const;

private:

FRIEND_TEST_ALL_PREFIXES(BubbleFrameViewBasicTest, NonClientHitTest);

FRIEND_TEST_ALL_PREFIXES(BubbleDelegateTest, CreateDelegate);

- BubbleFrameView* GetBubbleFrameView() const;

// Get bubble bounds from the anchor point and client view's preferred size.

gfx::Rect GetBubbleBounds();

« chrome/browser/ui/views/avatar_menu_bubble_view.cc ('K') | « chrome/browser/ui/views/avatar_menu_bubble_view.cc ('k') | ui/views/bubble/bubble_delegate.cc » ('j') | no next file with comments »