Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8909002: views: Convert IsEnabled() to just enabled() since it's just a simple accessor. (Closed)

Created:
9 years ago by tfarina
Modified:
9 years ago
CC:
chromium-reviews, asanka, penghuang+watch_chromium.org, James Su, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, Randy Smith (Not in Mondays), dcheng, davidbarr+watch_chromium.org, yuzo+watch_chromium.org, yusukes+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

views: Convert IsEnabled() to just enabled() since it's just a simple accessor. BUG=105879 R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114012

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -117 lines) Patch
M chrome/browser/chromeos/drop_shadow_label.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/shutdown_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/take_photo_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/username_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 12 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/setting_level_bubble_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/reload_button_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/accessibility/native_view_accessibility_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/accessible_pane_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/button_dropdown.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +0 lines, -1 line 0 comments Download
ui/views/controls/button/custom_button.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M ui/views/controls/button/text_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/label.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/link.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M ui/views/controls/menu/menu_item_view_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_item_view_linux.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_item_view_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/native_control.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/native_control_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/native_control_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/progress_bar.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M ui/views/controls/resize_area.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/native_table_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/table_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_win.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.cc View 5 chunks +4 lines, -9 lines 0 comments Download
M ui/views/widget/drop_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/root_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years ago (2011-12-11 01:20:52 UTC) #1
Ben Goodger (Google)
9 years ago (2011-12-11 21:48:40 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698