Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: client/html/src/NodeWrappingImplementation.dart

Issue 8907051: Fix _ChildrenNodeList#forEach. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/html/release/htmlimpl.dart ('k') | client/tests/client/client.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/html/src/NodeWrappingImplementation.dart
diff --git a/client/html/src/NodeWrappingImplementation.dart b/client/html/src/NodeWrappingImplementation.dart
index e44f063d90561367ea38532a67d75f848a251d21..f677df58939e1513a52d593eebd84b90980f668f 100644
--- a/client/html/src/NodeWrappingImplementation.dart
+++ b/client/html/src/NodeWrappingImplementation.dart
@@ -24,8 +24,8 @@ class _ChildrenNodeList implements NodeList {
}
void forEach(void f(Node element)) {
- for (var node in _childNodes) {
- f(LevelDom.wrapNode(node));
+ for (int i = 0, len = _childNodes.length; i < len; i++) {
Jacob 2011/12/14 23:00:13 what if the children change while iterating? to be
nweiz 2011/12/14 23:21:38 That makes me realize, this could be implemented m
+ f(LevelDom.wrapNode(_childNodes[i]));
}
}
« no previous file with comments | « client/html/release/htmlimpl.dart ('k') | client/tests/client/client.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698