Fix _ChildrenNodeList#forEach.

client/html/src/NodeWrappingImplementation.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _ChildrenNodeList implements NodeList {
   // Raw node.
   final _node;
   final _childNodes;
 
   _ChildrenNodeList._wrap(var node)
     : _childNodes = node.childNodes,
       _node = node;
 
   List<Node> _toList() {
     final output = new List(_childNodes.length);
     for (int i = 0, len = _childNodes.length; i < len; i++) {
       output[i] = LevelDom.wrapNode(_childNodes[i]);
     }
     return output;
   }
 
   Node get first() {
     return LevelDom.wrapNode(_node.firstChild);
   }
 
   void forEach(void f(Node element)) {
-    for (var node in _childNodes) {
-      f(LevelDom.wrapNode(node));
+    for (int i = 0, len = _childNodes.length; i < len; i++) {

[Jacob, 2011/12/14 23:00:13]

what if the children change while iterating?
to be safe we have to copy the children to a temp array
or mitigate the issue somewhat by not caching len and adding a comment warning
of the edge case.
 

[nweiz, 2011/12/14 23:21:38]

That makes me realize, this could be implemented much more cleanly by just using
_toList.

+      f(LevelDom.wrapNode(_childNodes[i]));
     }
   }
 
   Collection<Node> filter(bool f(Node element)) {
     List<Node> output = new List<Node>();
     forEach((Node element) {
       if (f(element)) {
         output.add(element);
       }
     });
@@ skipping 173 matching lines @@
   // array.
   Node insertBefore(Node newChild, Node refChild) {
     return LevelDom.wrapNode(_ptr.insertBefore(
         LevelDom.unwrap(newChild), LevelDom.unwrap(refChild)));
   }
 
   Node clone(bool deep) {
     return LevelDom.wrapNode(_ptr.cloneNode(deep));
   }
 }