Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 8899010: Fix cause of uninitialized memory read in ExtensionService unit_tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased, ready for review Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_sync_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 56cf5249c2654faef4ac1f74bc44ab9f13c3bd4c..402e0e40a4707dc48ff6cdee14a0fa76126feb12 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1444,7 +1444,8 @@ void ExtensionService::ProcessExtensionSyncData(
bundle.pending_sync_data[extension_sync_data.id()] = extension_sync_data;
CheckForUpdatesSoon();
}
- if (extension_sync_data.notifications_disabled() !=
+ if (extension_sync_data.type() == Extension::SYNC_TYPE_APP &&
+ extension_sync_data.notifications_disabled() !=
extension_prefs_->IsAppNotificationDisabled(id)) {
extension_prefs_->SetAppNotificationDisabled(
id, extension_sync_data.notifications_disabled());
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_sync_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698