chrome/browser/extensions/extension_sync_data.cc - Issue 8899010: Fix cause of uninitialized memory read in ExtensionService unit_tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_sync_data.cc

Issue 8899010: Fix cause of uninitialized memory read in ExtensionService unit_tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased, ready for review Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_sync_data.cc

diff --git a/chrome/browser/extensions/extension_sync_data.cc b/chrome/browser/extensions/extension_sync_data.cc

index db7266d28cd71e668c604e26bece42755337488b..2bd1bfc5c8b785fb306310e57a8908187ddd8ad1 100644

--- a/chrome/browser/extensions/extension_sync_data.cc

+++ b/chrome/browser/extensions/extension_sync_data.cc

@@ -27,7 +27,11 @@ ExtensionSyncData::ExtensionSyncData(const SyncData& sync_data)

}

ExtensionSyncData::ExtensionSyncData(const SyncChange& sync_change)

- : uninstalled_(sync_change.change_type() == SyncChange::ACTION_DELETE) {

+ : uninstalled_(sync_change.change_type() == SyncChange::ACTION_DELETE),

+ enabled_(false),

+ incognito_enabled_(false),

+ type_(Extension::SYNC_TYPE_NONE),

+ notifications_disabled_(false) {

PopulateFromSyncData(sync_change.sync_data());

}