Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 8899010: Fix cause of uninitialized memory read in ExtensionService unit_tests (Closed)

Created:
9 years ago by asargent_no_longer_on_chrome
Modified:
9 years ago
Reviewers:
Matt Perry
CC:
chromium-reviews, jstritar+watch_chromium.org, Alexander Potapenko, Timur Iskhodzhanov, mihaip+watch_chromium.org, Aaron Boodman, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Fix cause of uninitialized memory read in ExtensionService unit_tests In crrev.com/113111 I checked in code that reads a app state boolean from an ExtensionSyncData object which is uninitialized. This fixes the initialization for the relevant constructor, and also limits reading that value to only when the extension is an app. BUG=106549 TEST=valgrind run of ExtensionService sync-related unit_tests should come back clean Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113926

Patch Set 1 #

Patch Set 2 : rebased, ready for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_sync_data.cc View 1 chunk +5 lines, -1 line 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
asargent_no_longer_on_chrome
For your reviewing pleasure...
9 years ago (2011-12-09 22:52:50 UTC) #1
Matt Perry
lgtm
9 years ago (2011-12-09 23:05:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8899010/6
9 years ago (2011-12-10 00:00:32 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-10 02:31:26 UTC) #4
Change committed as 113926

Powered by Google App Engine
This is Rietveld 408576698