Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 8897022: Revert 113895 - <video> decode in hardware! (Closed)

Created:
9 years ago by Ami GONE FROM CHROMIUM
Modified:
9 years ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, yzshen+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, apatrick_chromium, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), piman+watch_chromium.org, scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Revert 113895 - <video> decode in hardware! This uses the GpuVideoDecodeAccelerator machinery (already written to enable ppapi to take advantage of OpenMAX HW where available) to decode <video> data. This increases idle CPU from 20% to 45% on one particularly large (internal) test video (red0.mp4), on an ARM crosbook. HW decode is done on a best-effort basis; if the GPU code doesn't know how to deal with a codec/profile we still fall back to ffmpeg for decode. Because the vast majority of chrome installs will be on HW with no video decode support (yet) we only attempt HW video decode on platforms we know have a shot at it. BUG=104579 TEST=manual testing w/ video test matrix, trybots. Review URL: http://codereview.chromium.org/8686010 TBR=fischman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -1119 lines) Patch
MM content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM content/common/gpu/media/omx_video_decode_accelerator.cc View 3 chunks +13 lines, -15 lines 0 comments Download
M content/common/gpu/media/omx_video_decode_accelerator_unittest.cc View 5 chunks +11 lines, -8 lines 0 comments Download
MM content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/gpu/gpu_video_decode_accelerator_host.cc View 1 chunk +1 line, -1 line 0 comments Download
MM content/renderer/media/audio_renderer_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
MM content/renderer/media/capture_video_decoder.h View 3 chunks +2 lines, -3 lines 0 comments Download
MM content/renderer/media/capture_video_decoder.cc View 3 chunks +3 lines, -3 lines 0 comments Download
MM content/renderer/media/capture_video_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
MM content/renderer/media/rtc_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
MM content/renderer/media/rtc_video_decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM content/renderer/media/rtc_video_decoder_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
MM content/renderer/render_view_impl.cc View 4 chunks +1 line, -21 lines 0 comments Download
D content/renderer/renderer_gpu_video_decoder_factories.h View 1 chunk +0 lines, -49 lines 0 comments Download
D content/renderer/renderer_gpu_video_decoder_factories.cc View 1 chunk +0 lines, -63 lines 0 comments Download
MM media/base/composite_filter.h View 1 chunk +0 lines, -3 lines 0 comments Download
MM media/base/composite_filter.cc View 4 chunks +2 lines, -19 lines 0 comments Download
MM media/base/composite_filter_unittest.cc View 2 chunks +3 lines, -15 lines 0 comments Download
MM media/base/filter_collection.h View 1 chunk +0 lines, -1 line 0 comments Download
MM media/base/filters.h View 3 chunks +5 lines, -8 lines 0 comments Download
MM media/base/filters.cc View 1 chunk +0 lines, -5 lines 0 comments Download
MM media/base/mock_filters.h View 2 chunks +1 line, -2 lines 0 comments Download
MM media/base/mock_filters.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/pipeline_impl.h View 2 chunks +4 lines, -5 lines 0 comments Download
MM media/base/pipeline_impl.cc View 7 chunks +11 lines, -21 lines 0 comments Download
MM media/base/pipeline_impl_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M media/base/video_decoder_config.h View 6 chunks +1 line, -31 lines 0 comments Download
M media/base/video_decoder_config.cc View 6 chunks +2 lines, -32 lines 0 comments Download
MM media/base/video_frame.h View 7 chunks +5 lines, -28 lines 0 comments Download
MM media/base/video_frame.cc View 5 chunks +6 lines, -42 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 3 chunks +0 lines, -44 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 5 chunks +26 lines, -7 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 3 chunks +15 lines, -18 lines 0 comments Download
D media/filters/gpu_video_decoder.h View 1 chunk +0 lines, -169 lines 0 comments Download
D media/filters/gpu_video_decoder.cc View 1 chunk +0 lines, -443 lines 0 comments Download
M media/filters/video_renderer_base.cc View 3 chunks +12 lines, -8 lines 0 comments Download
MM media/media.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
MM media/video/video_decode_accelerator.h View 2 chunks +19 lines, -3 lines 0 comments Download
MM ppapi/api/dev/pp_video_dev.idl View 3 chunks +3 lines, -5 lines 0 comments Download
MM ppapi/c/dev/pp_video_dev.h View 4 chunks +4 lines, -6 lines 0 comments Download
M webkit/media/webmediaplayer_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
MM webkit/media/webvideoframe_impl.h View 1 chunk +6 lines, -7 lines 0 comments Download
MM webkit/media/webvideoframe_impl.cc View 2 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ami GONE FROM CHROMIUM
9 years ago (2011-12-10 01:03:16 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698