Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 8896012: Revert 113823 - net: move pinning checks into the SSL socket. (Closed)

Created:
9 years ago by awong
Modified:
9 years ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 113823 - net: move pinning checks into the SSL socket. Previously we would reject requests with pinning errors at the URLRequest layer but, by that time, we would already have sent cookies. The commenting of the #ifdef is deliberate - it allows the builders to chew the code over. Once the builders are happy I'll land another change to uncomment the #ifdefs. This also happens to start unpicking the DNS certificate provenance stuff. BUG=none TEST=Verify that https://pinningtest.appspot.com fails to load in offical builds. Review URL: http://codereview.chromium.org/8865006 TBR=agl@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -55 lines) Patch
M net/socket/ssl_client_socket_nss.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 6 chunks +10 lines, -44 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 3 chunks +44 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
awong
9 years ago (2011-12-09 20:55:36 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698