Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 8894015: Merge 102405 - Source/WebCore: Improve handling of frame removal during requestAnimationFrame cal... (Closed)

Created:
9 years ago by jamesr
Modified:
9 years ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/912/
Visibility:
Public.

Description

Merge 102405 - Source/WebCore: Improve handling of frame removal during requestAnimationFrame callback invocation https://bugs.webkit.org/show_bug.cgi?id=74036 Reviewed by Adam Barth. See bug for details. Test: fast/animation/request-animation-frame-detach-element.html * dom/Document.cpp: (WebCore::Document::removedLastRef): (WebCore::Document::detach): * dom/Document.h: * dom/ScriptedAnimationController.cpp: (WebCore::ScriptedAnimationController::~ScriptedAnimationController): (WebCore::ScriptedAnimationController::serviceScriptedAnimations): (WebCore::ScriptedAnimationController::scheduleAnimation): * dom/ScriptedAnimationController.h: (WebCore::ScriptedAnimationController::create): (WebCore::ScriptedAnimationController::clearDocumentPointer): * page/FrameView.cpp: (WebCore::FrameView::serviceScriptedAnimations): LayoutTests: Add some tests for removing frames from the document while servicing requestAnimationFrame callbacks https://bugs.webkit.org/show_bug.cgi?id=74036 Reviewed by Adam Barth. * fast/animation/request-animation-frame-detach-element-expected.txt: Added. * fast/animation/request-animation-frame-detach-element.html: Added. BUG=106672 TBR=jamesr@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
A + LayoutTests/fast/animation/request-animation-frame-detach-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/animation/request-animation-frame-detach-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/dom/Document.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/WebCore/dom/ScriptedAnimationController.h View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/WebCore/dom/ScriptedAnimationController.cpp View 3 chunks +16 lines, -0 lines 0 comments Download
M Source/WebCore/page/FrameView.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
9 years ago (2011-12-09 20:32:25 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698