Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: Source/WebCore/dom/Document.cpp

Issue 8894015: Merge 102405 - Source/WebCore: Improve handling of frame removal during requestAnimationFrame cal... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/912/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/dom/Document.h ('k') | Source/WebCore/dom/ScriptedAnimationController.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * 10 *
(...skipping 594 matching lines...) Expand 10 before | Expand all | Expand 10 after
605 removeAllChildren(); 605 removeAllChildren();
606 606
607 m_markers->detach(); 607 m_markers->detach();
608 608
609 detachParser(); 609 detachParser();
610 610
611 m_cssCanvasElements.clear(); 611 m_cssCanvasElements.clear();
612 612
613 #if ENABLE(REQUEST_ANIMATION_FRAME) 613 #if ENABLE(REQUEST_ANIMATION_FRAME)
614 // FIXME: consider using ActiveDOMObject. 614 // FIXME: consider using ActiveDOMObject.
615 m_scriptedAnimationController = nullptr; 615 if (m_scriptedAnimationController)
616 m_scriptedAnimationController->clearDocumentPointer();
617 m_scriptedAnimationController.clear();
616 #endif 618 #endif
617 619
618 #ifndef NDEBUG 620 #ifndef NDEBUG
619 m_inRemovedLastRefFunction = false; 621 m_inRemovedLastRefFunction = false;
620 #endif 622 #endif
621 623
622 guardDeref(); 624 guardDeref();
623 } else { 625 } else {
624 #ifndef NDEBUG 626 #ifndef NDEBUG
625 m_deletionHasBegun = true; 627 m_deletionHasBegun = true;
(...skipping 1191 matching lines...) Expand 10 before | Expand all | Expand 10 after
1817 clearAXObjectCache(); 1819 clearAXObjectCache();
1818 1820
1819 stopActiveDOMObjects(); 1821 stopActiveDOMObjects();
1820 m_eventQueue->close(); 1822 m_eventQueue->close();
1821 #if ENABLE(FULLSCREEN_API) 1823 #if ENABLE(FULLSCREEN_API)
1822 m_fullScreenChangeEventTargetQueue.clear(); 1824 m_fullScreenChangeEventTargetQueue.clear();
1823 #endif 1825 #endif
1824 1826
1825 #if ENABLE(REQUEST_ANIMATION_FRAME) 1827 #if ENABLE(REQUEST_ANIMATION_FRAME)
1826 // FIXME: consider using ActiveDOMObject. 1828 // FIXME: consider using ActiveDOMObject.
1827 m_scriptedAnimationController = nullptr; 1829 if (m_scriptedAnimationController)
1830 m_scriptedAnimationController->clearDocumentPointer();
1831 m_scriptedAnimationController.clear();
1828 #endif 1832 #endif
1829 1833
1830 RenderObject* render = renderer(); 1834 RenderObject* render = renderer();
1831 1835
1832 // Send out documentWillBecomeInactive() notifications to registered element s, 1836 // Send out documentWillBecomeInactive() notifications to registered element s,
1833 // in order to stop media elements 1837 // in order to stop media elements
1834 documentWillBecomeInactive(); 1838 documentWillBecomeInactive();
1835 1839
1836 #if ENABLE(SHARED_WORKERS) 1840 #if ENABLE(SHARED_WORKERS)
1837 SharedWorkerRepository::documentDetached(this); 1841 SharedWorkerRepository::documentDetached(this);
(...skipping 3375 matching lines...) Expand 10 before | Expand all | Expand 10 after
5213 5217
5214 NodeListsNodeData* data = rareData()->nodeLists(); 5218 NodeListsNodeData* data = rareData()->nodeLists();
5215 5219
5216 String localTypeNames = typeNames.isNull() ? String("http://webkit.org/micro data/undefinedItemType") : typeNames; 5220 String localTypeNames = typeNames.isNull() ? String("http://webkit.org/micro data/undefinedItemType") : typeNames;
5217 ASSERT_UNUSED(list, list == data->m_microDataItemListCache.get(localTypeName s)); 5221 ASSERT_UNUSED(list, list == data->m_microDataItemListCache.get(localTypeName s));
5218 data->m_microDataItemListCache.remove(localTypeNames); 5222 data->m_microDataItemListCache.remove(localTypeNames);
5219 } 5223 }
5220 #endif 5224 #endif
5221 5225
5222 } // namespace WebCore 5226 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/WebCore/dom/Document.h ('k') | Source/WebCore/dom/ScriptedAnimationController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698