Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 8890089: [Sync] Add HistoryService::DeleteURLsForTest (Closed)

Created:
9 years ago by akalin
Modified:
9 years ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), brettw-cc_chromium.org
Visibility:
Public.

Description

[Sync] Add HistoryService::DeleteURLsForTest This is so that the sync performance tests don't need to wait for each URL delete to hit the disk before moving on to the next one. This is a speculative fix to stabilize the delete_typed_urls sync perf test. It also cuts down the runtime of the typed urls test from >20s to <10s or so. BUG=107040 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114458

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M chrome/browser/history/history.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/history/history.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc View 2 chunks +5 lines, -3 lines 2 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
+sky for history stuff, +atwilson for sync stuff
9 years ago (2011-12-14 00:45:14 UTC) #1
sky
LGTM
9 years ago (2011-12-14 15:31:26 UTC) #2
Andrew T Wilson (Slow)
LGTM http://codereview.chromium.org/8890089/diff/1/chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc File chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc (right): http://codereview.chromium.org/8890089/diff/1/chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc#newcode76 chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc:76: const std::vector<history::URLRow>& urls = GetTypedUrlsFromClient(profile); This scares me, ...
9 years ago (2011-12-14 18:17:06 UTC) #3
akalin
9 years ago (2011-12-14 18:21:15 UTC) #4
http://codereview.chromium.org/8890089/diff/1/chrome/browser/sync/test/integr...
File
chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc
(right):

http://codereview.chromium.org/8890089/diff/1/chrome/browser/sync/test/integr...
chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc:76:
const std::vector<history::URLRow>& urls = GetTypedUrlsFromClient(profile);
On 2011/12/14 18:17:07, Andrew T Wilson wrote:
> This scares me, but I trust you when you say this is guaranteed to work.

Yeap, see
http://herbsutter.com/2008/01/01/gotw-88-a-candidate-for-the-most-important-c...
.

I like it because it's the closest C++ can come to let bindings.

Powered by Google App Engine
This is Rietveld 408576698