[Sync] Add HistoryService::DeleteURLsForTest

chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc

Index: chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc
diff --git a/chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc b/chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc
index 715a32d59e5d01920952709ed29724c464ed05b2..d1b4d3d4fedca499ce9e2d736a42fb8426422bc0 100644
--- a/chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc
+++ b/chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc
@@ -12,7 +12,7 @@
 
 using typed_urls_helper::AddUrlToHistory;
 using typed_urls_helper::AssertAllProfilesHaveSameURLsAsVerifier;
-using typed_urls_helper::DeleteUrlFromHistory;
+using typed_urls_helper::DeleteUrlsFromHistory;
 using typed_urls_helper::GetTypedUrlsFromClient;
 
 // This number should be as far away from a multiple of
@@ -73,11 +73,13 @@ void TypedUrlsSyncPerfTest::UpdateURLs(int profile) {
 }
 
 void TypedUrlsSyncPerfTest::RemoveURLs(int profile) {
-  std::vector<history::URLRow> urls = GetTypedUrlsFromClient(profile);
+  const std::vector<history::URLRow>& urls = GetTypedUrlsFromClient(profile);

[Andrew T Wilson (Slow), 2011/12/14 18:17:07]

This scares me, but I trust you when you say this is guaranteed to work.

[akalin, 2011/12/14 18:21:15]

Yeap, see
http://herbsutter.com/2008/01/01/gotw-88-a-candidate-for-the-most-important-c...
.

I like it because it's the closest C++ can come to let bindings.

+  std::vector<GURL> gurls;
   for (std::vector<history::URLRow>::const_iterator it = urls.begin();
        it != urls.end(); ++it) {
-    DeleteUrlFromHistory(profile, it->url());
+    gurls.push_back(it->url());
   }
+  DeleteUrlsFromHistory(profile, gurls);
 }
 
 int TypedUrlsSyncPerfTest::GetURLCount(int profile) {