chromeos: Don't fire candidate window open/close events for suggestion window.

chromeos: Don't fire candidate window open/close events for suggestion window.

For our purposes so far (IME/omnibox coordination) we don't plan to take any action when the suggestion window is opened/closed.  See design doc for more details.

BUG=chromium-os:17763
TEST=manually


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113991

[Yusuke Sato, 2011-12-09 07:38:35]

LGTM with a nit.

http://codereview.chromium.org/8888038/diff/2001/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/candidate_window.cc (right):

http://codereview.chromium.org/8888038/diff/2001/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/candidate_window.cc:949: static bool
was_open = false;
I think this does not work if the view object is created more than once. What
about moving the variable to candidate_window_view.h (as a non-static member
variable) for safety?

[falken, 2011-12-12 05:20:30]

On 2011/12/09 07:38:35, Yusuke Sato wrote:
> LGTM with a nit.
> 
>
http://codereview.chromium.org/8888038/diff/2001/chrome/browser/chromeos/inpu...
> File chrome/browser/chromeos/input_method/candidate_window.cc (right):
> 
>
http://codereview.chromium.org/8888038/diff/2001/chrome/browser/chromeos/inpu...
> chrome/browser/chromeos/input_method/candidate_window.cc:949: static bool
> was_open = false;
> I think this does not work if the view object is created more than once. What
> about moving the variable to candidate_window_view.h (as a non-static member
> variable) for safety?

Good point, thanks.  Done.

[commit-bot: I haz the power, 2011-12-12 05:20:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/8888038/5001

[commit-bot: I haz the power, 2011-12-12 06:38:44]

Change committed as 113991