chromeos: Don't fire candidate window open/close events for suggestion window.

chrome/browser/chromeos/input_method/candidate_window.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/input_method/candidate_window.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 868 matching lines @@
   // Add the candidate area.
   layout->StartRow(0, 0);
   layout->AddView(candidate_area_);  // |candidate_area_| is owned by |this|.
 
   // Add the footer area.
   layout->StartRow(0, 0);
   layout->AddView(footer_area_);  // |footer_area_| is owned by |this|.
 }
 
 void CandidateWindowView::HideAll() {
-  bool was_visible = IsCandidateWindowOpen();
   parent_frame_->Hide();
-  if (was_visible) {
-    FOR_EACH_OBSERVER(Observer, observers_, OnCandidateWindowClosed());
-  }
+  NotifyIfCandidateWindowOpenedOrClosed();
 }
 
 void CandidateWindowView::HideLookupTable() {
-  bool was_visible = IsCandidateWindowOpen();
   candidate_area_->Hide();
   if (preedit_area_->IsShown())
     ResizeAndMoveParentFrame();
   else
     parent_frame_->Hide();
-  if (was_visible) {
-    FOR_EACH_OBSERVER(Observer, observers_, OnCandidateWindowClosed());
-  }
+
+  NotifyIfCandidateWindowOpenedOrClosed();
 }
 
 InformationTextArea* CandidateWindowView::GetAuxiliaryTextArea() {
   return (lookup_table_.orientation == InputMethodLookupTable::kHorizontal ?
           header_area_ : footer_area_);
 }
 
 void CandidateWindowView::HideAuxiliaryText() {
   GetAuxiliaryTextArea()->Hide();
   ResizeAndMoveParentFrame();
@@ skipping 20 matching lines @@
   preedit_area_->Show();
   ResizeAndMoveParentFrame();
   parent_frame_->Show();
 }
 
 void CandidateWindowView::UpdatePreeditText(const std::string& utf8_text) {
   preedit_area_->SetText(utf8_text);
 }
 
 void CandidateWindowView::ShowLookupTable() {
-  bool was_visible = IsCandidateWindowOpen();
   candidate_area_->Show();
   ResizeAndMoveParentFrame();
   parent_frame_->Show();
-  if (!was_visible) {
+
+  NotifyIfCandidateWindowOpenedOrClosed();
+}
+
+void CandidateWindowView::NotifyIfCandidateWindowOpenedOrClosed() {
+  static bool was_open = false;

[Yusuke Sato, 2011/12/09 07:38:35]

I think this does not work if the view object is created more than once. What
about moving the variable to candidate_window_view.h (as a non-static member
variable) for safety?

+
+  bool is_open = IsCandidateWindowOpen();
+  if (!was_open && is_open) {
     FOR_EACH_OBSERVER(Observer, observers_, OnCandidateWindowOpened());
+  } else if (was_open && !is_open) {
+    FOR_EACH_OBSERVER(Observer, observers_, OnCandidateWindowClosed());
   }
+  was_open = is_open;
 }
 
 bool CandidateWindowView::ShouldUpdateCandidateViews(
     const InputMethodLookupTable& old_table,
     const InputMethodLookupTable& new_table) {
 
   // Check if mozc lookup table location is changed.
   if (old_table.mozc_candidates.has_window_location() ||
       new_table.mozc_candidates.has_window_location()) {
 
@@ skipping 218 matching lines @@
   // Compute views size in |layout|.
   // If we don't call this function, GetHorizontalOffset() often
   // returns invalid value (returns 0), then candidate window
   // moves right from the correct position in ResizeAndMoveParentFrame().
   // TODO(nhiroki): Figure out why it returns invalid value.
   // It seems that the x-position of the candidate labels is not set.
   layout->Layout(candidate_area_contents);
 }
 
 bool CandidateWindowView::IsCandidateWindowOpen() const {
-  return candidate_area_->IsVisible() && candidate_area_->IsShown();
+  return !is_suggestion_window_location_available_ &&
+      candidate_area_->IsVisible() && candidate_area_->IsShown();
 }
 
 void CandidateWindowView::SelectCandidateAt(int index_in_page) {
   const int current_page_index = ComputePageIndex(lookup_table_);
   if (current_page_index < 0) {
     LOG(ERROR) << "Invalid lookup_table: " << lookup_table_.ToString();
     return;
   }
 
   const int cursor_absolute_index =
@@ skipping 574 matching lines @@
   impl_->AddObserver(observer);
 }
 
 void CandidateWindowController::RemoveObserver(
     CandidateWindowController::Observer* observer) {
   impl_->RemoveObserver(observer);
 }
 
 }  // namespace input_method
 }  // namespace chromeos