Issue 8888028: drover: Fix --milestone to take the highest-valued branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8888028: drover: Fix --milestone to take the highest-valued branch. (Closed)

Created:
9 years ago by James Hawkins

Modified:
9 years ago

Reviewers:
laforge, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

drover: Fix --milestone to take the highest-valued branch. The previous code erroneously took the lowest-valued branch. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113681

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	drover.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

http://codereview.chromium.org/8888028/diff/1/drover.py File drover.py (right): http://codereview.chromium.org/8888028/diff/1/drover.py#newcode407 drover.py:407: branch = sorted_branches[len(sorted_branches) - 1] The pythonic way is ...

9 years ago (2011-12-08 22:41:19 UTC) #3

James Hawkins

9 years ago (2011-12-08 23:40:46 UTC) #4

On 2011/12/08 22:41:19, Marc-Antoine Ruel wrote:
> http://codereview.chromium.org/8888028/diff/1/drover.py
> File drover.py (right):
> 
> http://codereview.chromium.org/8888028/diff/1/drover.py#newcode407
> drover.py:407: branch = sorted_branches[len(sorted_branches) - 1]
> The pythonic way is [-1]

I'll make this change.

Expand Messages | Collapse Messages