Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: drover.py

Issue 8888028: drover: Fix --milestone to take the highest-valued branch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: drover.py
===================================================================
--- drover.py (revision 113672)
+++ drover.py (working copy)
@@ -404,7 +404,7 @@
# The following returns a sorted list of the keys of |branch_dict|.
sorted_branches = sorted(branch_dict)
- branch = sorted_branches[0]
+ branch = sorted_branches[len(sorted_branches) - 1]
M-A Ruel 2011/12/08 22:41:19 The pythonic way is [-1]
# If all keys match, the branch is the same for all platforms given
# |milestone|. This is the safe case, so return the branch.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698