DOM fixes for types that are not marked hidden

frog/gen.dart

Index: frog/gen.dart
diff --git a/frog/gen.dart b/frog/gen.dart
index cae3ab91433fb980b67ec7494fb83d070f148d8b..04786b428b3871cce14efe8975aa1759308844df 100644
--- a/frog/gen.dart
+++ b/frog/gen.dart
@@ -165,7 +165,8 @@ class WorldGenerator {
       // TODO(jmesserly): we can't accurately track if DOM types are
       // created or not, so we need to prepare to handle them.
       // This should be fixed by tightening up the return types in DOM.
-      if ((type.isUsed || type.isHiddenNativeType) && type.isClass) {
+      if ((type.isUsed || type.library == world.dom

[sra1, 2011/12/08 22:04:32]

I assume isUsed get set when a subclass is used?

Then there is a work-around for Event:  
  if (false) { <create a subclass of event> }

But that is harder to do in the source than first appears.

Could you do a pre-walk over the types, marking *Foo types and their parents as
used?

[Jennifer Messerly, 2011/12/08 22:17:48]

Maybe. The "hidden" bit isn't really related, though--that was just a quick hack
to make the DOM work and to make your "makeA" tests work.

What we need is to be more explicit--for every native method, including corelib,
coreimpl, DOM and any special Frog tests, we need the list of types it might
create--similar to what we do some places in corelib. (the block of code
following the "native" declaration).

+          || type.isHiddenNativeType) && type.isClass) {
         writeType(type);
 
         if (type.isGeneric) {
@@ -280,7 +281,7 @@ class WorldGenerator {
         }
       }
     }
-    
+
     if (type.isTop) {
       // no preludes for top type
     } else if (type.constructors.length == 0) {