Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: client/dom/frog/frog_dom.dart

Issue 8888027: DOM fixes for types that are not marked hidden (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/gen.dart » ('j') | frog/gen.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/frog/frog_dom.dart
diff --git a/client/dom/frog/frog_dom.dart b/client/dom/frog/frog_dom.dart
index 469fb558f29c8500643b1fcc4762858646771e8a..efa2773eb040dc6c93a71d28ecc4a7f82484f84b 100644
--- a/client/dom/frog/frog_dom.dart
+++ b/client/dom/frog/frog_dom.dart
@@ -12,7 +12,9 @@
// #source('src/_FactoryProviders.dart');
-class Window extends DOMWindow {}
+// TODO(jmesserly): We need to be smarter about inheriting from a hidden native
+// type (in this case DOMWindow)
+class Window extends DOMWindow native "*Window" {}
DOMWindow get window() native "return window;";
// TODO(vsm): Revert to Dart method when 508 is fixed.
HTMLDocument get document() native "return window.document;";
@@ -3215,7 +3217,9 @@ class HTMLMarqueeElement extends HTMLElement native "*HTMLMarqueeElement" {
void stop() native;
}
-class HTMLMediaElement extends HTMLElement native "HTMLMediaElement" {
+// TODO(jmesserly): this is marked as hidden until we figure out how to fix
+// DumpRenderTree on Mac.
+class HTMLMediaElement extends HTMLElement native "*HTMLMediaElement" {
sra1 2011/12/08 22:04:32 This will likely break FireFox since it is not a l
Jennifer Messerly 2011/12/08 22:17:48 As the comment says, it doesn't exist on DumpRende
static final int HAVE_CURRENT_DATA = 2;
« no previous file with comments | « no previous file | frog/gen.dart » ('j') | frog/gen.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698