Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 8885012: Replace PP_ALLOW_THIS_IN_INITIALIZER_LIST macro (Closed)

Created:
9 years ago by Takashi Toyoshima
Modified:
9 years ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Move the PP_ALLOW_THIS_IN_INITIALIZER_LIST macro from test_utils.h to pp_macros.idl. Now, PP_ALLOW_THIS_IN_INITIALIZER_LIST macro is provided for not only tests but also C++ api implementation in NaCl. BUG=87310 TEST=ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113615

Patch Set 1 #

Patch Set 2 : revise #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -18 lines) Patch
M ppapi/api/pp_macros.idl View 1 1 chunk +16 lines, -0 lines 0 comments Download
M ppapi/c/pp_macros.h View 1 2 chunks +17 lines, -1 line 0 comments Download
M ppapi/tests/test_flash.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_transport.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_utils.h View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Takashi Toyoshima
Hi, Dave. As you said in review of http://codereview.chromium.org/8821010/, I make a change to move ...
9 years ago (2011-12-08 13:36:07 UTC) #1
dmichael (off chromium)
Lgtm On Dec 8, 2011 6:36 AM, <toyoshim@chromium.org> wrote: > Reviewers: brettw, dmichael, piman, > ...
9 years ago (2011-12-08 13:45:19 UTC) #2
dmichael (off chromium)
Oops, could you fix up where the comment says ALLOW instead of PP_ALLOW? (My fault) ...
9 years ago (2011-12-08 14:06:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8885012/3001
9 years ago (2011-12-08 14:28:56 UTC) #4
commit-bot: I haz the power
Try job failure for 8885012-3001 (retry) on linux_rel for steps "browser_tests, ui_tests". It's a second ...
9 years ago (2011-12-08 15:41:02 UTC) #5
Takashi Toyoshima
hum... old WebSocket server seems to hang unexpectedly in the try bot. Anyway, I retry ...
9 years ago (2011-12-08 16:00:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8885012/3001
9 years ago (2011-12-08 16:00:57 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-08 17:32:27 UTC) #8
Change committed as 113615

Powered by Google App Engine
This is Rietveld 408576698