Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: ppapi/api/pp_macros.idl

Issue 8885012: Replace PP_ALLOW_THIS_IN_INITIALIZER_LIST macro (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revise Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/c/pp_macros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/api/pp_macros.idl
diff --git a/ppapi/api/pp_macros.idl b/ppapi/api/pp_macros.idl
index f189d4a9361939972cd8bcc43b3cb59ca0480ab2..fc6e4ad898bd90c37079519ea5cc173f009a94cd 100644
--- a/ppapi/api/pp_macros.idl
+++ b/ppapi/api/pp_macros.idl
@@ -86,6 +86,22 @@ PP_COMPILE_ASSERT_SIZE_IN_BYTES_IMPL(NAME, struct NAME, SIZE)
#define PP_COMPILE_ASSERT_ENUM_SIZE_IN_BYTES(NAME, SIZE) \
PP_COMPILE_ASSERT_SIZE_IN_BYTES_IMPL(NAME, enum NAME, SIZE)
+/* This is roughly copied from base/compiler_specific.h, and makes it possible
+ to pass 'this' in a constructor initializer list, when you really mean it.
+ E.g.:
+ Foo::Foo(MyInstance* instance)
+ : PP_ALLOW_THIS_IN_INITIALIZER_LIST(callback_factory_(this)) {}
+ */
+#if defined(COMPILER_MSVC)
+# define PP_ALLOW_THIS_IN_INITIALIZER_LIST(code) \
+ __pragma(warning(push)) \
+ __pragma(warning(disable:4355)) \
+ code \
+ __pragma(warning(pop))
+#else
+# define PP_ALLOW_THIS_IN_INITIALIZER_LIST(code) code
+#endif
+
/**
* @}
* End of addtogroup PP
« no previous file with comments | « no previous file | ppapi/c/pp_macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698