Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 8884001: Turned on PbufferImageTransportSurface as default image transport for vista and win 7 (not XP). (Closed)

Created:
9 years ago by apatrick_chromium
Modified:
9 years ago
Reviewers:
jam, jonathan.backer
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Turned on PbufferImageTransportSurface as default image transport for vista and win 7 (not XP). Also implemented PbufferImageTransportSurface::SetVisible by making the underlying surface 1x1 when it is not visible. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113761

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M content/common/gpu/image_transport_surface_win.cc View 1 7 chunks +31 lines, -5 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
apatrick_chromium
9 years ago (2011-12-08 01:05:26 UTC) #1
jonathan.backer
LGTM I'm assuming you've thoroughly tested (I haven't on my end). http://codereview.chromium.org/8884001/diff/1/content/public/common/content_switches.h File content/public/common/content_switches.h (right): ...
9 years ago (2011-12-08 16:07:02 UTC) #2
apatrick_chromium
Done. I have tested it. Just waiting for you to review http://codereview.chromium.org/8869007/ :) http://codereview.chromium.org/8884001/diff/1/content/public/common/content_switches.h File ...
9 years ago (2011-12-08 21:20:06 UTC) #3
jonathan.backer
On 2011/12/08 21:20:06, apatrick_chromium wrote: > Done. I have tested it. Just waiting for you ...
9 years ago (2011-12-08 21:26:39 UTC) #4
apatrick_chromium
+jam for content/public/common
9 years ago (2011-12-09 00:39:38 UTC) #5
jam
lgtm btw there are now more owners in content/public :) http://src.chromium.org/viewvc/chrome/trunk/src/content/public/OWNERS
9 years ago (2011-12-09 01:57:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/8884001/6001
9 years ago (2011-12-09 03:29:18 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-09 04:44:31 UTC) #8
Change committed as 113761

Powered by Google App Engine
This is Rietveld 408576698