Issue 8869007: GLSurface::Resize implementations release the current context if they are current before resize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8869007: GLSurface::Resize implementations release the current context if they are current before resize. (Closed)

Created:
9 years ago by apatrick_chromium

Modified:
9 years ago

Reviewers:
jonathan.backer

CC:
chromium-reviews, dhollowa+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

GLSurface::Resize implementations release the current context if they are current before resize. This is because, if the newly allocated surface happens to have the same handle / address, a subsequent MakeCurrent will think that the surface has not changed and early out. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113677

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
	M	ui/gfx/gl/gl_surface_egl.cc	View		2 chunks	+15 lines, -1 line	0 comments	Download
	M	ui/gfx/gl/gl_surface_osmesa.cc	View		3 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages