Issue 8882001: Exclude SamplingProfileTest.Sample from win valgrind bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8882001: Exclude SamplingProfileTest.Sample from win valgrind bots. (Closed)

Created:
9 years ago by cbentzel

Modified:
9 years ago

Reviewers:
Timur Iskhodzhanov, Sigurður Ásgeirsson

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Exclude SamplingProfileTest.Sample from win valgrind bots. This test makes assumptions that the native code will run, which is at odds with how valgrind works. BUG=None TBR=siggi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113517

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt	View		1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

http://codereview.chromium.org/8882001/diff/1/tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt File tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt (right): http://codereview.chromium.org/8882001/diff/1/tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt#newcode12 tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt:12: SamplingProfileTest.Sample You've meant SamplingProfilerTest.Sample ?

9 years ago (2011-12-08 09:49:47 UTC) #1

cbentzel

9 years ago (2011-12-08 10:40:53 UTC) #2

http://codereview.chromium.org/8882001/diff/1/tools/valgrind/gtest_exclude/ba...
File tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt (right):

http://codereview.chromium.org/8882001/diff/1/tools/valgrind/gtest_exclude/ba...
tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt:12:
SamplingProfileTest.Sample
On 2011/12/08 09:49:48, Timur Iskhodzhanov wrote:
> You've meant SamplingProfilerTest.Sample ?

Whoops, yes.

Expand Messages | Collapse Messages