Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt

Issue 8882001: Exclude SamplingProfileTest.Sample from win valgrind bots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt
diff --git a/tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt b/tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt
index 525648c280b5943e70678b91a6ec1402b9a2c59c..920a518103cf7d65cca5374e777abaae09fe692c 100644
--- a/tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt
+++ b/tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt
@@ -5,3 +5,8 @@ TimeTicks.WinRollover
TimeTicks.Deltas
TimeTicks.HighResNow
TimerTest.RepeatingTimer*
+
+# This Windows-native sampling profiler test does not
+# work under valgrind because it assumes the original
+# code runs, not the modified version under valgrind.
+SamplingProfileTest.Sample
Timur Iskhodzhanov 2011/12/08 09:49:48 You've meant SamplingProfilerTest.Sample ?
cbentzel 2011/12/08 10:40:53 Whoops, yes.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698