Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: client/dom/frog_dom.dart

Issue 8879044: Work-around Frog codegen bug where Window is derived from native DOMWindow. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/frog/frog_dom.dart ('k') | client/dom/generated/src/frog/Console.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/frog_dom.dart
diff --git a/client/dom/frog_dom.dart b/client/dom/frog_dom.dart
index 1f6877722991ec76b23fff68b978fa88cb333222..79ad5217a77c6cf047668c19bb0e0460dcbfc570 100644
--- a/client/dom/frog_dom.dart
+++ b/client/dom/frog_dom.dart
@@ -536,7 +536,10 @@
#source('src/_ListIterators.dart');
#source('src/_Lists.dart');
-class Window extends DOMWindow {}
+// TODO(jmesserly): 'native' here is aWork-around for Frog bug. Frog needs to
+// be smarter about inheriting from a hidden native type (in this case
+// DOMWindow)
+class Window extends DOMWindow native "*Window" {}
DOMWindow get window() native "return window;";
// TODO(vsm): Revert to Dart method when 508 is fixed.
HTMLDocument get document() native "return window.document;";
« no previous file with comments | « client/dom/frog/frog_dom.dart ('k') | client/dom/generated/src/frog/Console.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698