Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: client/dom/frog/frog_dom.dart

Issue 8879044: Work-around Frog codegen bug where Window is derived from native DOMWindow. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/dom/frog_dom.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/frog/frog_dom.dart
diff --git a/client/dom/frog/frog_dom.dart b/client/dom/frog/frog_dom.dart
index e49d092a4ebbe5ebf55fee51a4ce5e92d66d9157..3e382b8dbdd000728867d9c0605a824184dee2f6 100644
--- a/client/dom/frog/frog_dom.dart
+++ b/client/dom/frog/frog_dom.dart
@@ -12,8 +12,9 @@
// #source('src/_FactoryProviders.dart');
-// TODO(jmesserly): We need to be smarter about inheriting from a hidden native
-// type (in this case DOMWindow)
+// TODO(jmesserly): 'native' here is aWork-around for Frog bug. Frog needs to
+// be smarter about inheriting from a hidden native type (in this case
+// DOMWindow)
class Window extends DOMWindow native "*Window" {}
DOMWindow get window() native "return window;";
// TODO(vsm): Revert to Dart method when 508 is fixed.
@@ -836,7 +837,7 @@ class CompositionEvent extends UIEvent native "*CompositionEvent" {
void initCompositionEvent(String typeArg, bool canBubbleArg, bool cancelableArg, DOMWindow viewArg, String dataArg) native;
}
-class Console native "=console" {
+class Console native "=(typeof console == 'undefined' ? {} : console)" {
MemoryInfo memory;
@@ -3217,9 +3218,7 @@ class HTMLMarqueeElement extends HTMLElement native "*HTMLMarqueeElement" {
void stop() native;
}
-// TODO(jmesserly): this is marked as hidden until we figure out how to fix
-// DumpRenderTree on Mac.
-class HTMLMediaElement extends HTMLElement native "*HTMLMediaElement" {
+class HTMLMediaElement extends HTMLElement native "HTMLMediaElement" {
static final int HAVE_CURRENT_DATA = 2;
« no previous file with comments | « no previous file | client/dom/frog_dom.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698