Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 8879042: Add a --archive-id option to update_manifest.py. (Closed)

Created:
9 years ago by der Springer
Modified:
9 years ago
Reviewers:
mball, noelallen1
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add a --archive-id option to update_manifest.py. The --archive-id option allows you to specify the archive id that is used to build the BigStore URL for the SDK tarballs. This id overrides the default id that looks like "pepper_15_1347". BUG=none TEST=native_client_sdk/src/scons run_update_manifest_test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M native_client_sdk/src/build_tools/sdk_tools/update_manifest.py View 5 chunks +20 lines, -5 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/update_manifest_test.py View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
der Springer
9 years ago (2011-12-09 01:21:26 UTC) #1
mball
LGTM After you commit, make sure to update the Release Sheriff Guide with instructions on ...
9 years ago (2011-12-09 15:32:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dspringer@chromium.org/8879042/1
9 years ago (2011-12-09 17:17:18 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-09 17:17:24 UTC) #4
Presubmit check for 8879042-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2011 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  native_client_sdk/src/build_tools/sdk_tools/update_manifest.py \
  native_client_sdk/src/build_tools/tests/update_manifest_test.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
native_client_sdk/src/build_tools/sdk_tools/update_manifest.py,native_client_sdk/src/build_tools/tests/update_manifest_test.py

Missing LGTM from an OWNER for:
native_client_sdk/src/build_tools/sdk_tools/update_manifest.py,native_client_sdk/src/build_tools/tests/update_manifest_test.py

Presubmit checks took 1.4s to calculate.

Powered by Google App Engine
This is Rietveld 408576698