Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: native_client_sdk/src/build_tools/sdk_tools/update_manifest.py

Issue 8879042: Add a --archive-id option to update_manifest.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/tests/update_manifest_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/sdk_tools/update_manifest.py
diff --git a/native_client_sdk/src/build_tools/sdk_tools/update_manifest.py b/native_client_sdk/src/build_tools/sdk_tools/update_manifest.py
index d020e0a226b7c23235e772a2b449c8978d7ce297..0929688c58465082ce28abf16e1a34180d5c12a0 100755
--- a/native_client_sdk/src/build_tools/sdk_tools/update_manifest.py
+++ b/native_client_sdk/src/build_tools/sdk_tools/update_manifest.py
@@ -52,7 +52,8 @@ BUILD_TOOLS_OUT = os.path.join(NACL_SDK_ROOT, 'scons-out', 'build', 'obj',
BUNDLE_SDK_TOOLS = 'sdk_tools'
BUNDLE_PEPPER_MATCHER = re.compile('^pepper_([0-9]+)$')
-IGNORE_OPTIONS = set(['gsutil', 'manifest_file', 'upload', 'root_url'])
+IGNORE_OPTIONS = set([
+ 'archive_id', 'gsutil', 'manifest_file', 'upload', 'root_url'])
class Error(Exception):
@@ -133,7 +134,7 @@ class UpdateSDKManifest(sdk_update.SDKManifest):
Args:
options: the object containing the remaining unused options attributes.
- bundl_name: The name of the bundle, or None if it's missing.'''
+ bundle_name: The name of the bundle, or None if it's missing.'''
# Any option left in the list should have value = None
for key, val in options.__dict__.items():
if val != None and key not in IGNORE_OPTIONS:
@@ -277,8 +278,15 @@ class UpdateSDKManifestFile(sdk_update.SDKManifestFile):
if options.desc is None:
options.desc = ('Chrome %s bundle, revision %s' %
(options.bundle_version, options.bundle_revision))
- root_url = '%s/pepper_%s_%s' % (options.root_url, options.bundle_version,
- options.bundle_revision)
+ root_url = options.root_url
+ if options.archive_id:
+ # Support archive names like trunk.113440 or 17.0.963.3, which is how
+ # the Chrome builders archive things.
+ root_url = '/'.join([root_url, options.archive_id])
+ else:
+ # This is the old archive naming scheme
+ root_url = '%s/pepper_%s_%s' % (root_url, options.bundle_version,
+ options.bundle_revision)
options.mac_arch_url = '/'.join([root_url, 'naclsdk_mac.tgz'])
options.linux_arch_url = '/'.join([root_url, 'naclsdk_linux.tgz'])
options.win_arch_url = '/'.join([root_url, 'naclsdk_win.exe'])
@@ -311,6 +319,13 @@ def main(argv):
# Setup options
parser.add_option(
+ '-a', '--archive-id', dest='archive_id',
+ default=None,
+ help='Archive identifier, produced by the Chromium builders; string '
+ 'like "trunk.113440" or "17.0.963.3". Used with --root-url to '
+ 'build the full archive URL. If not set the archive id defaults to '
+ '"pepper_<version>_<revision>"')
+ parser.add_option(
'-b', '--bundle-version', dest='bundle_version',
type='int',
default=None,
@@ -348,7 +363,7 @@ def main(argv):
'-r', '--recommended', dest='recommended',
choices=sdk_update.YES_NO_LITERALS,
default=None,
- help='Required: whether this bundle is recommended. one of "yes" or "no"')
+ help='Required: whether this bundle is recommended. One of "yes" or "no"')
parser.add_option(
'-R', '--root-url', dest='root_url',
default='http://commondatastorage.googleapis.com/nativeclient-mirror/'
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/tests/update_manifest_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698