Issue 8879033: Removing MessageLoop::QuitTask() from chrome_frame/

Issue 8879033: Removing MessageLoop::QuitTask() from chrome_frame/ (Closed)

Created:
9 years ago by dcheng

Modified:
9 years ago

Reviewers:
robertshield

CC:
chromium-reviews, darin-cc_chromium.org, amit, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removing MessageLoop::QuitTask() from chrome_frame/ base/task.h is going away and being replaced by base/bind.h and base/callback.h. This CL was automatically generated by sed. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113920

Patch Set 1 #

Patch Set 2 : Fixed. #

Patch Set 3 : . #

Patch Set 4 : Really fixed #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
M	chrome_frame/delete_chrome_history.cc	View	1 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/test/chrome_frame_automation_mock.h	View	1 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/test/chrome_frame_automation_mock.cc	View	1 3	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome_frame/test/net/fake_external_tab.cc	View	1 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/test/test_server_test.cc	View	1 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/test/test_with_web_server.cc	View	1 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

dcheng

On 2011/12/08 20:19:03, robertshield wrote: > lgtm I need to redo the sed run on ...

9 years ago (2011-12-08 20:20:19 UTC) #3

robertshield

On 2011/12/08 20:39:19, dcheng wrote: > PTAL, I fixed the escaping errors from my first ...

9 years ago (2011-12-09 20:02:12 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8879033/8

9 years ago (2011-12-09 20:04:27 UTC) #6

commit-bot: I haz the power

Try job failure for 8879033-8 (retry) on win_rel for step "ui_tests". It's a second try, ...

9 years ago (2011-12-09 23:38:27 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8879033/8

9 years ago (2011-12-10 00:25:29 UTC) #8

Change committed as 113920

Expand Messages | Collapse Messages