chrome_frame/test/chrome_frame_automation_mock.cc - Issue 8879033: Removing MessageLoop::QuitTask() from chrome_frame/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/test/chrome_frame_automation_mock.cc

Issue 8879033: Removing MessageLoop::QuitTask() from chrome_frame/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Really fixed Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_frame/test/chrome_frame_automation_mock.cc

diff --git a/chrome_frame/test/chrome_frame_automation_mock.cc b/chrome_frame/test/chrome_frame_automation_mock.cc

index 4da64bc4be12b5ea72e95697e4fb1367acb566b5..65c34f09c8be5a9ccfa2b12faacd28c4ead9d7a3 100644

--- a/chrome_frame/test/chrome_frame_automation_mock.cc

+++ b/chrome_frame/test/chrome_frame_automation_mock.cc

@@ -16,7 +16,7 @@ TEST(ChromeFrame, FLAKY_Launch) {

MessageLoopForUI loop;

AutomationMockLaunch mock_launch(&loop, kLongWaitTimeout);

- loop.PostDelayedTask(FROM_HERE, new MessageLoop::QuitTask, kLongWaitTimeout);

+ loop.PostDelayedTask(FROM_HERE, MessageLoop::QuitClosure(), kLongWaitTimeout);

mock_launch.Navigate("about:blank");

loop.RunWithDispatcher(NULL);

@@ -27,7 +27,7 @@ TEST(ChromeFrame, Navigate) {

MessageLoopForUI loop;

AutomationMockNavigate mock_navigate(&loop, kLongWaitTimeout);

- loop.PostDelayedTask(FROM_HERE, new MessageLoop::QuitTask, kLongWaitTimeout);

+ loop.PostDelayedTask(FROM_HERE, MessageLoop::QuitClosure(), kLongWaitTimeout);

mock_navigate.NavigateRelativeFile(L"postmessage_basic_frame.html");

loop.RunWithDispatcher(NULL);

@@ -38,7 +38,7 @@ TEST(ChromeFrame, PostMessage) {

MessageLoopForUI loop;

AutomationMockPostMessage mock_postmessage(&loop, kLongWaitTimeout);

- loop.PostDelayedTask(FROM_HERE, new MessageLoop::QuitTask, kLongWaitTimeout);

+ loop.PostDelayedTask(FROM_HERE, MessageLoop::QuitClosure(), kLongWaitTimeout);

mock_postmessage.NavigateRelativeFile(L"postmessage_basic_frame.html");

loop.RunWithDispatcher(NULL);

@@ -52,7 +52,7 @@ TEST(ChromeFrame, FLAKY_RequestStart) {

AutomationMockHostNetworkRequestStart mock_request_start(&loop,

kLongWaitTimeout);

- loop.PostDelayedTask(FROM_HERE, new MessageLoop::QuitTask, kLongWaitTimeout);

+ loop.PostDelayedTask(FROM_HERE, MessageLoop::QuitClosure(), kLongWaitTimeout);

mock_request_start.NavigateRelative(L"postmessage_basic_frame.html");

loop.RunWithDispatcher(NULL);