Issue 8879029: Reflect ONC parse status correctly

Issue 8879029: Reflect ONC parse status correctly (Closed)

Created:
9 years ago by kmixter1

Modified:
9 years ago

Reviewers:
achuithb, Charlie Lee, mmenke, stevenjb

CC:
chromium-reviews, nkostylev+watch_chromium.org, eroman, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reflect ONC parse status correctly BUG=chromium-os:23931 TEST=import incorrect and correctly formatted ONC files Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113856

Patch Set 1 #

Total comments: 3

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/cros/network_library.cc	View		1 chunk	+2 lines, -1 line	2 comments	Download
	M	chrome/browser/resources/net_internals/chromeos_view.js	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

achuithb

lgtm http://codereview.chromium.org/8879029/diff/1/chrome/browser/chromeos/cros/network_library.cc File chrome/browser/chromeos/cros/network_library.cc (right): http://codereview.chromium.org/8879029/diff/1/chrome/browser/chromeos/cros/network_library.cc#newcode2870 chrome/browser/chromeos/cros/network_library.cc:2870: return (parser.GetNetworkConfigsSize() != 0 || nit: don't need ...

9 years ago (2011-12-08 19:34:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmixter@chromium.org/8879029/1

9 years ago (2011-12-08 20:07:02 UTC) #3

commit-bot: I haz the power

Presubmit check for 8879029-1 failed and returned exit status 1. Running presubmit commit checks ...

9 years ago (2011-12-08 20:07:05 UTC) #4

kmixter1

Added owners for two directories. http://codereview.chromium.org/8879029/diff/1/chrome/browser/chromeos/cros/network_library.cc File chrome/browser/chromeos/cros/network_library.cc (right): http://codereview.chromium.org/8879029/diff/1/chrome/browser/chromeos/cros/network_library.cc#newcode2870 chrome/browser/chromeos/cros/network_library.cc:2870: return (parser.GetNetworkConfigsSize() != 0 ...

9 years ago (2011-12-08 20:17:08 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmixter@chromium.org/8879029/1

9 years ago (2011-12-09 17:25:32 UTC) #8

Change committed as 113856

Expand Messages | Collapse Messages