chrome/browser/chromeos/cros/network_library.cc - Issue 8879029: Reflect ONC parse status correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/cros/network_library.cc

Issue 8879029: Reflect ONC parse status correctly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/cros/network_library.cc

diff --git a/chrome/browser/chromeos/cros/network_library.cc b/chrome/browser/chromeos/cros/network_library.cc

index d791ce582ff31272ef2b4ad2cf8095cc4042f2ff..787a5c120af94b256119efac7aa87397990cebd6 100644

--- a/chrome/browser/chromeos/cros/network_library.cc

+++ b/chrome/browser/chromeos/cros/network_library.cc

@@ -2867,7 +2867,8 @@ bool NetworkLibraryImplBase::LoadOncNetworks(const std::string& onc_blob,

CallConfigureService(network->unique_id(), &dict);

}

- return parser.GetNetworkConfigsSize() != 0;

+ return (parser.GetNetworkConfigsSize() != 0 ||

achuithb 2011/12/08 19:34:17 nit: don't need the outer parens.

kmixter1 2011/12/08 20:17:12 True - I find they make multi-line expressions lik

+ parser.GetCertificatesSize() != 0);

}

////////////////////////////////////////////////////////////////////////////