Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8879013: Deprecate WEBKIT thread (Closed)

Created:
9 years ago by joth
Modified:
9 years ago
CC:
chromium-reviews, jstritar+watch_chromium.org, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., Steve Block, Ben Murdoch
Visibility:
Public.

Description

Deprecate WEBKIT thread BUG=106839 TEST=try servers pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115116

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : update after rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -136 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_database_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_indexed_db_helper.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data_local_storage_helper.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data_local_storage_helper_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/browsing_data_remover.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_remover_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_data_deleter.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_thread_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/dom_storage_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/dom_storage_context.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M content/browser/in_process_webkit/dom_storage_message_filter.cc View 1 2 10 chunks +11 lines, -11 lines 0 comments Download
M content/browser/in_process_webkit/dom_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_context.cc View 7 chunks +14 lines, -11 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 2 33 chunks +35 lines, -34 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_key_utility_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/in_process_webkit/webkit_context.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/in_process_webkit/webkit_context_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/webkit_thread.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/webkit_thread_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/browser/browser_thread.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/shell_browser_context.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/shell_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
joth
In follow up to https://groups.google.com/a/google.com/group/chrome-owp/browse_thread/thread/17dc2bf4e9e5f194#
9 years ago (2011-12-13 14:15:31 UTC) #1
jam
rubberstamp lgtm (just looked at browser_thread.h)
9 years ago (2011-12-13 14:49:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/8879013/4001
9 years ago (2011-12-16 10:06:26 UTC) #3
commit-bot: I haz the power
Presubmit check for 8879013-4001 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-16 10:06:41 UTC) #4
joth
+davemoore for profile/OWNERS
9 years ago (2011-12-16 10:22:39 UTC) #5
joth
+ all of chrome/profiles/OWNERS -> owner approval please.
9 years ago (2011-12-19 10:52:38 UTC) #6
Miranda Callahan
On 2011/12/19 10:52:38, joth wrote: > + all of chrome/profiles/OWNERS > > -> owner approval ...
9 years ago (2011-12-19 14:47:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/8879013/4001
9 years ago (2011-12-19 14:57:16 UTC) #8
commit-bot: I haz the power
Try job failure for 8879013-4001 (retry) on linux_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-19 15:19:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/8879013/18001
9 years ago (2011-12-20 10:42:36 UTC) #10
commit-bot: I haz the power
9 years ago (2011-12-20 12:29:01 UTC) #11 
Change committed as 115116

Powered by Google App Engine
This is Rietveld 408576698