Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: content/browser/in_process_webkit/webkit_thread.cc

Issue 8879013: Deprecate WEBKIT thread (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update after rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/in_process_webkit/webkit_thread.cc
diff --git a/content/browser/in_process_webkit/webkit_thread.cc b/content/browser/in_process_webkit/webkit_thread.cc
index 8d1dd78c5620b66aa05ac10da0ae31b9ec8c71c2..bb1ae406fd5f709c7401e67803af4fca0810a6e3 100644
--- a/content/browser/in_process_webkit/webkit_thread.cc
+++ b/content/browser/in_process_webkit/webkit_thread.cc
@@ -22,14 +22,15 @@ WebKitThread::~WebKitThread() {
// MessageLoop::Current is sometimes NULL and other times valid and there's
// no BrowserThread object. Can't check that CurrentlyOn is not IO since
// some unit tests set that BrowserThread for other checks.
- DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::WEBKIT));
+ DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::WEBKIT_DEPRECATED));
}
void WebKitThread::Initialize() {
DCHECK(!webkit_thread_.get());
if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kSingleProcess)) {
- // TODO(jorlow): We need a better story for single process mode.
+ // TODO(joth): As this cannot work in single process mode use of the
+ // webkit thread is deprecated; see http://crbug.com/106839.
return;
}
@@ -39,7 +40,7 @@ void WebKitThread::Initialize() {
}
WebKitThread::InternalWebKitThread::InternalWebKitThread()
- : content::BrowserThreadImpl(BrowserThread::WEBKIT) {
+ : content::BrowserThreadImpl(BrowserThread::WEBKIT_DEPRECATED) {
}
WebKitThread::InternalWebKitThread::~InternalWebKitThread() {

Powered by Google App Engine
This is Rietveld 408576698