Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: frog/member.dart

Issue 8879006: frog: detect when getter/setter has incorrect number of arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/minfrog » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/member.dart
diff --git a/frog/member.dart b/frog/member.dart
index 4f971cbd9c6ed01937e3c3a8b9380b8b835ee399..c054f99d54a451fba14165d8756461082765444a 100644
--- a/frog/member.dart
+++ b/frog/member.dart
@@ -535,8 +535,20 @@ class PropertyMember extends Member {
}
resolve() {
- if (getter != null) getter.resolve();
- if (setter != null) setter.resolve();
+ if (getter != null) {
+ getter.resolve();
+ if (getter.parameters.length != 0) {
+ world.error('getter methods should take no arguments',
+ getter.definition.span);
+ }
+ }
+ if (setter != null) {
+ setter.resolve();
+ if (setter.parameters.length != 1) {
Jennifer Messerly 2011/12/08 03:22:30 is it worth warning if getter.returnType.isVoid, o
Siggi Cherem (dart-lang) 2011/12/08 20:43:53 addressing in follow up CL.
+ world.error('setter methods should take a single argument',
+ setter.definition.span);
+ }
+ }
library._addMember(this);
}
« no previous file with comments | « no previous file | frog/minfrog » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698