frog: detect when getter/setter has incorrect number of arguments.

frog/member.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** A formal parameter to a [Method]. */
 class Parameter {
   FormalNode definition;
   Member method;
 
   String name;
@@ skipping 517 matching lines @@
       parent = c.baseMember;
     } else {
       parent = parentMember;
     }
 
     if (getter == null) getter = parent.getter;
     if (setter == null) setter = parent.setter;
   }
 
   resolve() {
-    if (getter != null) getter.resolve();
-    if (setter != null) setter.resolve();
+    if (getter != null) {
+      getter.resolve();
+      if (getter.parameters.length != 0) {
+        world.error('getter methods should take no arguments',
+            getter.definition.span);
+      }
+    }
+    if (setter != null) {
+      setter.resolve();
+      if (setter.parameters.length != 1) {

[Jennifer Messerly, 2011/12/08 03:22:30]

is it worth warning if getter.returnType.isVoid, or !setter.returnType.isVoid?

[Siggi Cherem (dart-lang), 2011/12/08 20:43:53]

addressing in follow up CL.

+        world.error('setter methods should take a single argument',
+            setter.definition.span);
+      }
+    }
 
     library._addMember(this);
   }
 }
 
 
 class ConcreteMember extends Member {
   final Member baseMember;
   Type returnType;
   List<Parameter> parameters;
@@ skipping 1197 matching lines @@
   }
 
   void forEach(void f(Member member)) {
     factories.forEach((_, Map constructors) {
       constructors.forEach((_, Member member) {
         f(member);
       });
     });
   }
 }