Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: content/common/gpu/gpu_channel_manager.cc

Issue 8877001: Add more CHECK in GPU and NPAPI process on invalid file descriptors (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: NOTREACHED changed to CHECK(false). Thanks piman! Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/gpu_channel_manager.cc
diff --git a/content/common/gpu/gpu_channel_manager.cc b/content/common/gpu/gpu_channel_manager.cc
index cacb7eb61b815cf4b903f543d8af5134e34af5d2..f31de5ba51f7613ed844affdee7ddb6f786f16be 100644
--- a/content/common/gpu/gpu_channel_manager.cc
+++ b/content/common/gpu/gpu_channel_manager.cc
@@ -77,10 +77,12 @@ void GpuChannelManager::OnEstablishChannel(int renderer_id) {
content::GPUInfo gpu_info;
GpuChannelMap::const_iterator iter = gpu_channels_.find(renderer_id);
- if (iter == gpu_channels_.end())
+ if (iter == gpu_channels_.end()) {
channel = new GpuChannel(this, watchdog_, renderer_id, false);
- else
+ } else {
+ CHECK(false);
ddorwin 2011/12/08 19:17:27 If this is temporary, there should be a TODO to cl
xhwang 2011/12/08 19:37:49 This should be temporary as I am not confident tha
channel = iter->second;
+ }
DCHECK(channel != NULL);

Powered by Google App Engine
This is Rietveld 408576698