Add more CHECK in GPU and NPAPI process on invalid file descriptors

content/common/gpu/gpu_channel_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/gpu_channel_manager.h"
 
 #include "base/bind.h"
 #include "content/common/child_thread.h"
 #include "content/common/gpu/gpu_channel.h"
 #include "content/common/gpu/gpu_messages.h"
@@ skipping 59 matching lines @@
 bool GpuChannelManager::Send(IPC::Message* msg) {
   return gpu_child_thread_->Send(msg);
 }
 
 void GpuChannelManager::OnEstablishChannel(int renderer_id) {
   scoped_refptr<GpuChannel> channel;
   IPC::ChannelHandle channel_handle;
   content::GPUInfo gpu_info;
 
   GpuChannelMap::const_iterator iter = gpu_channels_.find(renderer_id);
-  if (iter == gpu_channels_.end())
+  if (iter == gpu_channels_.end()) {
     channel = new GpuChannel(this, watchdog_, renderer_id, false);
-  else
+  } else {
+    CHECK(false);

[ddorwin, 2011/12/08 19:17:27]

If this is temporary, there should be a TODO to clean this up. Otherwise, we
should just CHECK line 80 and remove new lines 82-85.

[xhwang, 2011/12/08 19:37:49]

This should be temporary as I am not confident that this CHECK is totally safe
in reality (as per piman's comment in
http://code.google.com/p/chromium/issues/detail?id=95732#c41).  It may be
improved later but is out of the scope of this investigation.

     channel = iter->second;
+  }
 
   DCHECK(channel != NULL);
 
   if (channel->Init(io_message_loop_, shutdown_event_))
     gpu_channels_[renderer_id] = channel;
   else
     channel = NULL;
 
   if (channel.get()) {
     channel_handle.name = channel->GetChannelName();
@@ skipping 47 matching lines @@
 void GpuChannelManager::LoseAllContexts() {
   MessageLoop::current()->PostTask(
       FROM_HERE,
       base::Bind(&GpuChannelManager::OnLoseAllContexts,
                  weak_factory_.GetWeakPtr()));
 }
 
 void GpuChannelManager::OnLoseAllContexts() {
   gpu_channels_.clear();
 }