Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2098)

Unified Diff: content/common/gpu/gpu_channel.cc

Issue 8877001: Add more CHECK in GPU and NPAPI process on invalid file descriptors (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: NOTREACHED changed to CHECK(false). Thanks piman! Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/gpu/gpu_channel_manager.cc » ('j') | content/common/gpu/gpu_channel_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/gpu_channel.cc
diff --git a/content/common/gpu/gpu_channel.cc b/content/common/gpu/gpu_channel.cc
index 27eb490fc6b069c01f3b7312aa693073e875c514..f14ae12383c2d07a7d7c0ed649205fa8969c02f7 100644
--- a/content/common/gpu/gpu_channel.cc
+++ b/content/common/gpu/gpu_channel.cc
@@ -417,8 +417,10 @@ void GpuChannel::OnCloseChannel() {
bool GpuChannel::Init(base::MessageLoopProxy* io_message_loop,
base::WaitableEvent* shutdown_event) {
// Check whether we're already initialized.
- if (channel_.get())
+ if (channel_.get()) {
+ CHECK(false);
ddorwin 2011/12/08 19:17:27 Replace the if statement with a CHECK? The return
xhwang 2011/12/08 19:37:49 This will be a temporary change.
return true;
+ }
// Map renderer ID to a (single) channel to that process.
std::string channel_name = GetChannelName();
« no previous file with comments | « no previous file | content/common/gpu/gpu_channel_manager.cc » ('j') | content/common/gpu/gpu_channel_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698