Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1699)

Issue 8873053: [debugger] noRefs option for fixing blowing array refs

Created:
9 years ago by indutny
Modified:
9 years ago
CC:
v8-dev, Søren Thygesen Gjesse, Peter Rybin
Base URL:
gh:v8/v8@master
Visibility:
Public.

Description

[debugger] noRefs option for fixing blowing array refs see https://gist.github.com/1230388 for example. When requesting bactrace - node.js SlowBuffer appears as an argument and it's every index is being put to the 'ref' property. In this patch I introduced noRefs argument, that'll skip reference allocation and remove 'ref' property from response. BUG= TEST= R=vegorov@chromium.org

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed runtime error #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/debug-debugger.js View 1 2 chunks +6 lines, -1 line 3 comments Download

Messages

Total messages: 12 (0 generated)
indutny
9 years ago (2011-12-09 08:38:16 UTC) #1
Vyacheslav Egorov (Chromium)
Pavel, can you please take a look and decide whether it makes sense to extend ...
9 years ago (2011-12-09 10:13:13 UTC) #2
pfeldman
I'll defer it to Søren and Peter since they are the ones to look after ...
9 years ago (2011-12-09 16:23:47 UTC) #3
pfeldman
9 years ago (2011-12-09 16:24:14 UTC) #4
ry
Is it possible to have this back ported to V8 3.6 ?
9 years ago (2011-12-09 18:34:50 UTC) #5
indutny
any status update?
9 years ago (2011-12-12 09:23:55 UTC) #6
Peter Rybin
http://codereview.chromium.org/8873053/diff/1/src/debug-debugger.js File src/debug-debugger.js (right): http://codereview.chromium.org/8873053/diff/1/src/debug-debugger.js#newcode1398 src/debug-debugger.js:1398: response.setOption('inlineRefs', true); Why includeRefs couldn't be re-used for your ...
9 years ago (2011-12-14 01:20:18 UTC) #7
indutny
No, it can't as you can see in gist that I attached to this patch, ...
9 years ago (2011-12-14 05:07:00 UTC) #8
Peter Rybin
http://codereview.chromium.org/8873053/diff/7002/src/debug-debugger.js File src/debug-debugger.js (right): http://codereview.chromium.org/8873053/diff/7002/src/debug-debugger.js#newcode1352 src/debug-debugger.js:1352: if (!this.options_ || !this.options_.noRefs) { What happens if you ...
9 years ago (2011-12-14 12:22:22 UTC) #9
indutny
http://codereview.chromium.org/8873053/diff/7002/src/debug-debugger.js File src/debug-debugger.js (right): http://codereview.chromium.org/8873053/diff/7002/src/debug-debugger.js#newcode1352 src/debug-debugger.js:1352: if (!this.options_ || !this.options_.noRefs) { You mean includeRefs: true, ...
9 years ago (2011-12-14 12:33:08 UTC) #10
Peter Rybin
http://codereview.chromium.org/8873053/diff/7002/src/debug-debugger.js File src/debug-debugger.js (right): http://codereview.chromium.org/8873053/diff/7002/src/debug-debugger.js#newcode1352 src/debug-debugger.js:1352: if (!this.options_ || !this.options_.noRefs) { On 2011/12/14 12:33:08, indutny ...
9 years ago (2011-12-14 18:13:55 UTC) #11
indutny
9 years ago (2011-12-14 18:16:15 UTC) #12
Oh, I made a typo : includeRefs => inlineRefs.

And I've tried using it and it works

Powered by Google App Engine
This is Rietveld 408576698