Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: src/debug-debugger.js

Issue 8873053: [debugger] noRefs option for fixing blowing array refs Base URL: gh:v8/v8@master
Patch Set: fixed runtime error Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug-debugger.js
diff --git a/src/debug-debugger.js b/src/debug-debugger.js
index 8cbe0b362cf423f7c8c70a94094aace081dd5b8f..ff66b6618c4d1d8091dcd8a40064bd13e7ed390f 100644
--- a/src/debug-debugger.js
+++ b/src/debug-debugger.js
@@ -1349,7 +1349,9 @@ ProtocolMessage.prototype.toJSONProtocol = function() {
bodyJson = ObjectToProtocolObject_(this.body, serializer);
}
json.body = bodyJson;
- json.refs = serializer.serializeReferencedObjects();
+ if (!this.options_ || !this.options_.noRefs) {
Peter Rybin 2011/12/14 12:22:22 What happens if you use includeRefs options here i
indutny 2011/12/14 12:33:08 You mean includeRefs: true, right? Looks like thi
Peter Rybin 2011/12/14 18:13:55 Your change allows user to reject "refs" from the
+ json.refs = serializer.serializeReferencedObjects();
+ }
}
if (this.message) {
json.message = this.message;
@@ -1395,6 +1397,9 @@ DebugCommandProcessor.prototype.processDebugJSONRequest = function(
if (args.inlineRefs || args.compactFormat) {
response.setOption('inlineRefs', true);
}
+ if (args.noRefs) {
+ response.setOption('noRefs', true);
+ }
if (!IS_UNDEFINED(args.maxStringLength)) {
response.setOption('maxStringLength', args.maxStringLength);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698