Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 8873037: Revert 113676 - Attempt 2 at : Makes tests either use mock compositor or mock (Closed)

Created:
9 years ago by sky
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Ian Vollick, dhollowa+watch_chromium.org, jonathan.backer, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., piman+watch_chromium.org, tfarina
Visibility:
Public.

Description

Revert 113676 - Attempt 2 at : Makes tests either use mock compositor or mock WebGraphicsContext3D depending upon which compositor we're running. This is needed to enable ui tests on the bots. I reverted first attempt as it broke some browser_tests. I've straightened that out in another patch, so this should be good go again. TBR since it's the same patch as before. BUG=104360 TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/8889022 TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -227 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_aura.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -9 lines 0 comments Download
M content/test/content_test_suite.cc View 2 chunks +1 line, -9 lines 0 comments Download
M ui/aura/aura.gyp View 4 chunks +2 lines, -16 lines 0 comments Download
M ui/aura/test/test_suite.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M ui/aura_shell/aura_shell.gyp View 2 chunks +1 line, -11 lines 0 comments Download
M ui/aura_shell/test_suite.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M ui/gfx/compositor/compositor.gyp View 4 chunks +1 line, -7 lines 0 comments Download
M ui/gfx/compositor/compositor_cc.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/gfx/compositor/compositor_cc.cc View 5 chunks +10 lines, -17 lines 0 comments Download
D ui/gfx/compositor/compositor_setup.h View 1 chunk +0 lines, -28 lines 0 comments Download
M ui/gfx/compositor/compositor_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/compositor/compositor_switches.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/compositor/layer_unittest.cc View 5 chunks +6 lines, -18 lines 0 comments Download
M ui/views/run_all_unittests.cc View 2 chunks +1 line, -10 lines 0 comments Download
M ui/views/view_unittest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M ui/views/views.gyp View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sky
9 years ago (2011-12-08 22:52:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698