Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 8889022: Attempt 2 at : Makes tests either use mock compositor or mock (Closed)

Created:
9 years ago by sky
Modified:
9 years ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Ian Vollick, dhollowa+watch_chromium.org, jonathan.backer, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., piman+watch_chromium.org, tfarina
Visibility:
Public.

Description

Attempt 2 at : Makes tests either use mock compositor or mock WebGraphicsContext3D depending upon which compositor we're running. This is needed to enable ui tests on the bots. I reverted first attempt as it broke some browser_tests. I've straightened that out in another patch, so this should be good go again. TBR since it's the same patch as before. BUG=104360 TEST=none TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -35 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_aura.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 3 chunks +10 lines, -1 line 0 comments Download
M chrome/test/ui/ui_test.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +9 lines, -1 line 0 comments Download
M content/test/content_test_suite.cc View 2 chunks +9 lines, -1 line 0 comments Download
M ui/aura/aura.gyp View 4 chunks +16 lines, -2 lines 0 comments Download
M ui/aura/test/test_suite.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M ui/aura_shell/aura_shell.gyp View 2 chunks +11 lines, -1 line 0 comments Download
M ui/aura_shell/test_suite.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/gfx/compositor/compositor.gyp View 4 chunks +7 lines, -1 line 0 comments Download
M ui/gfx/compositor/compositor_cc.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ui/gfx/compositor/compositor_cc.cc View 5 chunks +17 lines, -10 lines 0 comments Download
A ui/gfx/compositor/compositor_setup.h View 1 chunk +28 lines, -0 lines 0 comments Download
M ui/gfx/compositor/compositor_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/compositor/compositor_switches.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/compositor/layer_unittest.cc View 5 chunks +18 lines, -6 lines 0 comments Download
M ui/views/run_all_unittests.cc View 2 chunks +10 lines, -1 line 0 comments Download
M ui/views/view_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M ui/views/views.gyp View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
9 years ago (2011-12-08 22:01:01 UTC) #1
Ben Goodger (Google)
9 years ago (2011-12-08 22:07:13 UTC) #2
LGTM

On Thu, Dec 8, 2011 at 2:01 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Attempt 2 at : Makes tests either use mock compositor or mock
> WebGraphicsContext3D depending upon which compositor we're
> running. This is needed to enable ui tests on the bots.
>
> I reverted first attempt as it broke some browser_tests. I've
> straightened that out in another patch, so this should be good go
> again. TBR since it's the same patch as before.
>
> BUG=104360
> TEST=none
> TBR=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/8889022/<http://codereview.chromium.org/8889...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M build/all.gyp
>  M chrome/browser/chrome_browser_**main_extra_parts_aura.cc
>  M chrome/chrome_dll.gypi
>  M chrome/chrome_exe.gypi
>  M chrome/chrome_tests.gypi
>  M chrome/common/chrome_switches.**h
>  M chrome/common/chrome_switches.**cc
>  M chrome/test/base/chrome_test_**suite.cc
>  M chrome/test/ui/ui_test.cc
>  M content/content_tests.gypi
>  M content/test/content_test_**suite.cc
>  M ui/aura/aura.gyp
>  M ui/aura/test/test_suite.cc
>  M ui/aura_shell/aura_shell.gyp
>  M ui/aura_shell/test_suite.cc
>  M ui/gfx/compositor/compositor.**gyp
>  M ui/gfx/compositor/compositor_**cc.h
>  M ui/gfx/compositor/compositor_**cc.cc
>  A ui/gfx/compositor/compositor_**setup.h
>  M ui/gfx/compositor/compositor_**switches.h
>  M ui/gfx/compositor/compositor_**switches.cc
>  M ui/gfx/compositor/layer_**unittest.cc
>  M ui/views/run_all_unittests.cc
>  M ui/views/view_unittest.cc
>  M ui/views/views.gyp
>
>
>

Powered by Google App Engine
This is Rietveld 408576698