Create a visible shelf and constrain window movement

Create a visible shelf and constrain window movement


BUG=106432
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114459

[sky, 2011-12-14 06:23:05]

Did you already git add the background image?

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/launcher/launc...
File ui/aura_shell/launcher/launcher_view.cc (right):

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/launcher/launc...
ui/aura_shell/launcher/launcher_view.cc:181: virtual void Paint(int w, int h,
gfx::Canvas* canvas) {
PVERRODE

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/launcher/launc...
ui/aura_shell/launcher/launcher_view.cc:221: 
remove this line

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/shelf_layout_m...
File ui/aura_shell/shelf_layout_manager.cc (right):

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/shelf_layout_m...
ui/aura_shell/shelf_layout_manager.cc:122: gfx::Rect
launcher_bounds(launcher_->GetWindowScreenBounds());
What was wrong with the old code here? This change seems to assume the launcher
and status have the same height.

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/toplevel_layou...
File ui/aura_shell/toplevel_layout_manager.cc (right):

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/toplevel_layou...
ui/aura_shell/toplevel_layout_manager.cc:53: const gfx::Rect shelf_bounds =
shelf_->GetLauncherBounds();
I think it would be better to ask for the screen work area rather than go to the
shelf directly. That way if we allow the shelf to move to a side, or have other
things effect the work area this code won't change.

[DaveMoore, 2011-12-14 17:03:18]

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/launcher/launc...
File ui/aura_shell/launcher/launcher_view.cc (right):

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/launcher/launc...
ui/aura_shell/launcher/launcher_view.cc:181: virtual void Paint(int w, int h,
gfx::Canvas* canvas) {
On 2011/12/14 06:23:05, sky wrote:
> PVERRODE

Done.

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/launcher/launc...
ui/aura_shell/launcher/launcher_view.cc:221: 
On 2011/12/14 06:23:05, sky wrote:
> remove this line

Done.

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/shelf_layout_m...
File ui/aura_shell/shelf_layout_manager.cc (right):

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/shelf_layout_m...
ui/aura_shell/shelf_layout_manager.cc:122: gfx::Rect
launcher_bounds(launcher_->GetWindowScreenBounds());
It was left over from when I had a background in the status as well. I've gone
back to the old code.

On 2011/12/14 06:23:05, sky wrote:
> What was wrong with the old code here? This change seems to assume the
launcher
> and status have the same height.

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/toplevel_layou...
File ui/aura_shell/toplevel_layout_manager.cc (right):

http://codereview.chromium.org/8873036/diff/4001/ui/aura_shell/toplevel_layou...
ui/aura_shell/toplevel_layout_manager.cc:53: const gfx::Rect shelf_bounds =
shelf_->GetLauncherBounds();
On 2011/12/14 06:23:05, sky wrote:
> I think it would be better to ask for the screen work area rather than go to
the
> shelf directly. That way if we allow the shelf to move to a side, or have
other
> things effect the work area this code won't change.

Done.

[sky, 2011-12-14 18:26:31]

LGTM